Conversation
Refactoring: Rename Method
Reason for change:
The method selects a specified element based on the parameterized condition. So, the function name must be clearly mentioned as selectSpecifiedElement rather than just selects.
From select
To selectSpecifiedElement
| Particulars | Details | Comments |
|---|---|---|
| Commit Hash | com.gargoylesoftware.htmlunit | |
| Branch Name | asdc-assignment-set-1-extract-method | |
| Branch Link | https://github.com/bharatwaaj/htmlunit/tree/asdc-assignment-set-1-rename-method | |
| PR URL | #465 |
bharatwaaj
changed the title
Update CssStyleSheet.java
Rename Method as part of Refactoring
| */ | ||
| public static boolean selects(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { | ||
| public static boolean selectsSpecifiedElement(final BrowserVersion browserVersion, final Selector selector, |
| public static boolean selects(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { | ||
| public static boolean selectsSpecifiedElement(final BrowserVersion browserVersion, final Selector selector, | ||
| final DomElement element, final String pseudoElement, final boolean fromQuerySelectorAll) { |
Labels
None yet