duonglaiquang · GitHub

Conversation

@duonglaiquang

Copy link Copy Markdown

Contributor

This PR does the following

  • Fix Location.setHash() to update the page's WebRequest URL when the hash changes, ensuring page.getUrl() reflects the current hash

  • Fix WebClient.makeWebResponseForAboutUrl() to properly handle about:blank with hash fragments (e.g., about:blank#foo) instead of throwing MalformedURLException

@sonarqubecloud

Copy link Copy Markdown

@rbri

Copy link Copy Markdown

Member

@duonglaiquang this requires some time because i have some memories that i had hard times with this. Will have a look at this during the next days...

@rbri

@rbri

Copy link Copy Markdown

Member

Sorry, this got lost on my stack for version 5.0.0. But i fear i will make a 5.1.0 soon.

@rbri

@rbri

Copy link Copy Markdown

Member

merged, also duplicate your test as webdriver tests. All works fine. Thanks as always

Labels

None yet

2 participants

@duonglaiquang @rbri

Read the original on github.com ↗