Cabalist · GitHub

@Cabalist mentioned this pull request

Oct 3, 2020

Closed

pokidovea

@Cabalist

This was referenced

Oct 5, 2020

Closed

Closed

rbarrois added a commit that referenced this pull request

Dec 23, 2020
Unrolling the extra context for a declaration might depend on the
declaration's internals; that's typically the case with factory.Maybe:
the inner declarations might depend on the actual declaration used.
This adds `evaluate_pre` and a `evaluate_post` entrypoints to
declarations, more readable with regard to which build phase they are
used in.
Each of those will perform unrolling before calling the semi-public
actual function entrypoint (self.evaluate() for evaluate_pre,
self.call() for evaluate_post).
As a side effect, this fixes the issues with factory.Faker() when called
inside a factory.Maybe().
Closes #785 #786 #787 #788 #790 #796.

rbarrois added a commit that referenced this pull request

Dec 23, 2020
Unrolling the extra context for a declaration might depend on the
declaration's internals; that's typically the case with factory.Maybe:
the inner declarations might depend on the actual declaration used.
This adds `evaluate_pre` and a `evaluate_post` entrypoints to
declarations, more readable with regard to which build phase they are
used in.
Each of those will perform unrolling before calling the semi-public
actual function entrypoint (self.evaluate() for evaluate_pre,
self.call() for evaluate_post).
As a side effect, this fixes the issues with factory.Faker() when called
inside a factory.Maybe().
Closes #785 #786 #787 #788 #790 #796.

Read the original on github.com ↗