DanTup · GitHub

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how project folders are identified for package management, specifically for 'Get Packages for All Projects'. It introduces a new utility function, getPubWorkspaceOrPackageFolders, to correctly identify pub workspace roots and standalone packages, ensuring pub get is run only on these top-level entities rather than every sub-project within a workspace. The uniq utility function was updated for conciseness and potential performance. Several internal API changes were made, including making runCustomGetSDKCommand public, adding clearCaches to the internal API, and removing DaemonCapabilities from it. The resolvedPromise utility was simplified to resolve with undefined. Additionally, caching logic for project folder searches was improved to prevent stale results, and various test files were updated to use non-null assertions for privateApi.testController or make it optional where appropriate, along with a new test case to validate the pub workspace folder logic. The logging for CI builds was adjusted to delete logs for skipped tests as well, to save space.

Read the original on github.com ↗