Merged
Merged
Conversation
Pull request overview
This PR upgrades the vscode-languageclient dependency from v8.1.0 to v10.0.0-next.18 and enables the delayOpenNotifications feature to address GitHub issue #5176.
Key Changes:
- Upgraded vscode-languageclient to v10.0.0-next.18 with updated peer dependencies
- Updated StaticFeature interface API from
dispose()toclear()across all implementations - Simplified LspUriConverters interface to use function signatures instead of importing converter types
- Added
delayOpenNotifications: trueconfiguration to the LSP client options - Enhanced type handling for SnippetTextEdit in workspace edit processing
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| package.json | Updated vscode-languageclient dependency to version 10.0.0-next.18 |
| package-lock.json | Updated dependency tree including vscode-jsonrpc, vscode-languageserver-protocol, and vscode-languageserver-types to their corresponding next versions; marked balanced-match as dev dependency |
| src/shared/vscode/lsp_uri_converters.ts | Simplified LspConverters interface by replacing imported URIConverter types with direct function signatures |
| src/shared/vscode/lsp_common_capabilities.ts | Updated StaticFeature implementation to use clear() instead of dispose() |
| src/shared/vscode/interactive_refactors.ts | Updated StaticFeature implementation to use clear() instead of dispose() |
| src/shared/vscode/analyzer_update_diagnostic_information.ts | Updated StaticFeature implementation to use clear() instead of dispose() |
| src/extension/analysis/analyzer_snippet_text_edits.ts | Updated StaticFeature implementation to use clear() instead of dispose() |
| src/extension/analysis/analyzer.ts | Added delayOpenNotifications configuration and included ls.SnippetTextEdit in type union for handling snippet text edits |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
DanTup deleted the next-lsp-client branch
December 2, 2025 12:16