Pull Request Overview
This PR implements support for the Editor.getActiveLocation() service method in the Dart Tooling Daemon (DTD), addressing issue #5718. The change allows external tools to query the current active location in the VS Code editor.
- Adds the
editorGetActiveLocationservice method registration and implementation - Refactors active location handling to maintain state and support both events and queries
- Updates type definitions to separate
ActiveLocationinterface from event-specific properties
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/shared/services/tooling_daemon_services.ts | Adds new service method enum and refactors ActiveLocation interface |
| src/shared/services/tooling_daemon.ts | Updates method signatures and adds service registration overload |
| src/extension/dart/tooling_daemon.ts | Implements the getActiveLocation service and maintains active location state |
| src/test/dart/tooling_daemon/tooling_daemon.test.ts | Adds comprehensive tests for the new service method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
DanTup deleted the add-get-active-location-dtd-service-method branch
September 23, 2025 11:54