DanTup · GitHub

Merged

Merged

Conversation

@DanTup

Pull Request Overview

This PR adds macOS support for automatically adding the SDK to PATH and fixes an issue where users were prompted about a missing SDK immediately after successful installation. The fix includes breaking out of the installation loop after successful SDK cloning and implementing platform-specific PATH modification for macOS.

  • Add automatic PATH modification support for macOS by detecting shell profiles (.bash_profile for bash, .zshenv for zsh)
  • Fix infinite loop issue where users were re-prompted about missing SDK after successful installation
  • Update platform detection logic to include macOS alongside existing Windows support

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/extension/sdk/utils.ts Adds labeled break to exit installation loop after successful SDK clone
src/extension/commands/add_sdk_to_path.ts Implements macOS PATH modification with shell profile detection and file writing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DanTup

@DanTup

DanTup deleted the macos-add-to-path branch

September 18, 2025 10:44

Labels

in commands

Relates to commands (usually invoked from the command Palette)

in flutter

Relates to running Flutter apps

is bug fix is enhancement

An enhancement or improvement that should be listed in release notes but is not a bug fix.

Read the original on github.com ↗