Conversation
Contributor
Fixes #3628.
I'm not sure the recreateDecorationType is the right approach here but without it, I could not make the label update when changing the propriety on the settings.
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've added some comments (mostly trivial).
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments, but otherwise it's looking good - thanks! :)
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this lgtm - I'll pull it down and do a little testing when I get a min and if it's all good merge it in :-)
Closed
Member
This LGTM, thanks!
I found a quirk while testing, but it's not a result of this PR - we have it today (but it's easier to notice now there are more settings you might be customising) - I've opened #5265 about that.
labels
Sep 13, 2024
how to use dart.closingLabelsPrefix? couldn't find it in the release notes
Member
@Fernandomr88 it's a VS Code setting that shows up in the user/workspace settings:
Or if you're using the JSON settings editor:
"dart.closingLabelsPrefix": " # ",
Why not also let us change the color, fontSize and suffix ?
Maybe something like thise:
// ${className} //
Member