DanTup · GitHub

@DanTup

@DanTup DanTup commented

Apr 5, 2023

edited

Loading

Copy link Copy Markdown

Member

See #4021.

  • Address // TODO(dantup): This is right for Flutter, but must check package:test version for Dart too!
  • Remove const runTestsByLine = true
  • Address // TODO(dantup): Ensure we don't get here for Dart SDK or Bazel where we shouldn't use "dart run"?
  • Address // TODO(dantup): WIRE THIS UP!
  • Review if findMatchingDynamicNode should be taking lines into account?
  • Ensure there are tests that cover multiple tests in one run ("program": "foo_test.dart?line=1", "args": ["foo_test.dart?line=20"])
    • manually tested
  • Test all issues noted/referenced in Run tests using line/col to support groups/test with dynamic names #4021
  • Address // TODO(dantup): Ensure this never runs in the SDK, because it may produce unwanted package_configs?
  • Revert setting the default to "line" that was used for testing on the bots ( c00add9 )
  • Ensure Flutter has automated tests in the same way as Dart
    • manually tested

Fixes several issues:

@DanTup DanTup added is enhancement

An enhancement or improvement that should be listed in release notes but is not a bug fix.

in testing

Relates to test execution of Dart/Flutter tests for end users

labels

Apr 5, 2023

@DanTup DanTup added this to the v3.64.0 milestone

Apr 5, 2023

@DanTup

DanTup force-pushed the run-tests-by-line branch 4 times, most recently from 11ecd70 to c00add9 Compare

April 18, 2023 17:15

@DanTup DanTup changed the title Add some basic support for running tests by line number instead of name Add support for running tests by line number instead of name

Apr 19, 2023

@DanTup

DanTup merged commit e02dea9 into master

Apr 19, 2023

@DanTup

DanTup deleted the run-tests-by-line branch

April 19, 2023 17:56

Read the original on github.com ↗