DanTup · GitHub

Conversation

@Ascenio

Copy link Copy Markdown

Contributor

This could be subjective, but I think it's good to have a return type on every function. Every time I use the main snippet I find myself writing void anyway. You could also argue that I could make my own snippet, and that's true. But because dart is typed after all and fun uses void, why not?

@DanTup DanTup added in editor

Relates to code editing or language features

is enhancement

An enhancement or improvement that should be listed in release notes but is not a bug fix.

labels

Oct 4, 2021

@Ascenio

Copy link Copy Markdown

Contributor Author

I think there's something funny going on with tests.

@DanTup

Copy link Copy Markdown

Member

Thanks!

I don't believe either of the test failures are related to this. One is a known problem and the other looks like the SDK update check got a status 200 but not valid JSON and didn't handle that correctly. I'll improve the handling of that on the main branch.

@DanTup

@Ascenio

Labels

in editor

Relates to code editing or language features

is enhancement

An enhancement or improvement that should be listed in release notes but is not a bug fix.

2 participants

@Ascenio @DanTup

Read the original on github.com ↗