Merged

DanTup

merged 7 commits into

masterfrom

fix-dupe-completions

Sep 17, 2019

Conversation Commits (7)Checks Files changed

Merged

Don't include completions for each libraries importing them, only the first#1959
DanTup
merged 7 commits into
masterfrom
fix-dupe-completions

Conversation

DanTup commented
Sep 2, 2019

Copy link Copy Markdown

Member

No description provided.

DanTup added is bug fix in editor

Relates to code editing or language features

labels

Sep 2, 2019

DanTup added this to the v3.5.0 milestone

Sep 2, 2019

DanTup force-pushed the fix-dupe-completions branch from 389c487 to 3f8e1d1 Compare

September 3, 2019 07:11

DanTup force-pushed the fix-dupe-completions branch from 3f8e1d1 to d598044 Compare

September 17, 2019 12:07

DanTup added 7 commits

September 17, 2019 15:38

Don't include completions for all libraries importing them, only the …

66b89de

…first
Fixes #1958.

Update dart_completion_item_provider.ts

812c7b3

Revert "Update dart_completion_item_provider.ts"

b23980d

This reverts commit  13a3804 .

Revert "Don't include completions for all libraries importing them, o…

3f40bc5

…nly the first"
This reverts commit  15a2768 .

Don't add duplicate items to completion when imported by multiple lib…

4284c49

…raries
Fixes #1958.

Fix bug with de-duping Class vs Constructor

6d8dc28

Fix logic for skipping items already included in completions

a82b1f3

DanTup force-pushed the fix-dupe-completions branch from d598044 to a82b1f3 Compare

September 17, 2019 14:38

DanTup merged commit 9d5a9f4 into master

Sep 17, 2019

DanTup deleted the fix-dupe-completions branch

September 17, 2019 14:41

Labels

in editor

Relates to code editing or language features

is bug fix

Conversation

DanTup commented Sep 2, 2019

Labels

1 participant

DanTup commented
Sep 2, 2019