Copy link
Copy Markdown
Closes #6
- Support for full PHPUnit public API
- Optimized readability and maintainability of the code
- Organized the tests of the asserts in alphabetical order and according to their source
- Updated all docs about asserts
@Naktibalda Can you please take a look here and there.
It would be great if the changes were merged there to test through the CI here 👍 .
Removed unnecessary comments in tests, replaced expectException with expectThrowable
…erts.php does and increase maintainability. Ordered tests according to their source.
ghost marked this pull request as ready for review
August 15, 2020 20:45
ghost
mentioned this pull request
Copy link
Copy Markdown
Member
Cool, thank you for refactoring this part!
Could you look into failing tests?
Unit Tests (10) --------------------------------------------
PHP Fatal error: The modifiers of the trait method assertClassHasAttribute() are changed, but this method does not exist. Error in /home/runner/work/module-asserts/module-asserts/src/Codeception/Module/AbstractAsserts.php on line 8
Thank you!
Copy link
Copy Markdown
Author
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer command in Github Actions fails because it takes too long.
@TavoNiievez Please make this change #8 in your branch.
Copy link
Copy Markdown
Member
I will fix it myself.
