simonhammes · GitHub

@simonhammes

Copy link Copy Markdown

@simonhammes

@simonhammes

@TavoNiievez

Copy link Copy Markdown

Member

// The parents() method is deprecated since symfony/dom-crawler v5.3 (https://github.com/symfony/symfony/pull/39684)

I'm not sure about the need to add these comment lines to the source code. If someone wanted to know why those validations were added, they would do a git blame at that point and arrive at this PR, where the link to the Symfony PR should be.

@simonhammes

Copy link Copy Markdown

Author

// The parents() method is deprecated since symfony/dom-crawler v5.3 (https://github.com/symfony/symfony/pull/39684)

I'm not sure about the need to add these comment lines to the source code. If someone wanted to know why those validations were added, they would do a git blame at that point and arrive at this PR, where the link to the Symfony PR should be.

I can remove the comments if you'd like me to (?)

@TavoNiievez

Copy link Copy Markdown

Member

TavoNiievez

@kazuwsx

Copy link Copy Markdown

@TavoNiievez

@TavoNiievez

Copy link Copy Markdown

Member

@kazuwsx right now :) thanks for the reminder.

@simonhammes

simonhammes deleted the fix-symfony-dom-crawler-deprecation branch

August 30, 2021 16:23

Closed

Read the original on github.com ↗