nathanchance · GitHub

@nathanchance

Copy link Copy Markdown

Member

See each individual change for the linked issues for more context.

@nathanchance

Signed-off-by: Nathan Chancellor <nathan@kernel.org>

@nathanchance

@nathanchance

Copy link Copy Markdown

Member Author

2e1e313 is new in the latest push, as that failure happened overnight.

JustinStitt

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM.

I wonder though, if instead of providing the raw patches we could just have lore links that our system could fetch and apply? But as I'm writing this I realize that just complicates things. Food for thought, though.

@nathanchance

Copy link Copy Markdown

Member Author

I've thought about that as well and came to the same conclusion. It may be nice to eventually have a step that tries to apply the patches first and remove any that fail to apply so that the build does not fail when patches fail to apply like it current does. However, the current scheme makes cleaning up the patches more obvious; if there is no clear signal that a patch no longer applies, we may not clean up the patches in between adding new ones.

bwendling

@JustinStitt

Copy link Copy Markdown

Contributor

Merging ASAP since we have +2 review and we could potentially avoid some red in the matrix.

@JustinStitt

@nathanchance

Read the original on github.com ↗