Signed-off-by: Nathan Chancellor <nathan@kernel.org>
The trailing comma check is useful for iterables but not calls. Remove the trailing commas from calls and turn off the warning. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
As recently pointed out by ruff: boot-qemu.py:684:9: PLR5501 Consider using `elif` instead of `else` then `if` to remove one indentation level Signed-off-by: Nathan Chancellor <nathan@kernel.org>
As recently pointed out by ruff: utils.py:84:9: PLR5501 Consider using `elif` instead of `else` then `if` to remove one indentation level Signed-off-by: Nathan Chancellor <nathan@kernel.org>
This will be useful for follow up changes and helps reduce the amount of duplicate code. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
This will be rewritten to use classes for each architecture and encapsulate a lot of the internal running QEMU logic, which should be a little easier to maintain over the long run. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
This only supports x86 and x86_64 only, other architectures will be added with time. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
While clang cannot successfully compile an m68k kernel, I have hope that it one day will, so preemptively add support for it. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Keep these two options separate now that QEMU in the foreground runs in a separate method than QEMU in the background. Adjust the one location where we want interactive and gdb to do the same thing. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
…ethods Signed-off-by: Nathan Chancellor <nathan@kernel.org>
…links Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
The subclasses of QEMURunner can just initialize use_kvm in their constructors. ARMV7QEMURunner continues to use a separate method for initialization of use_kvm because of the check for 32-bit EL1. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Merged
nathanchance added a commit to nathanchance/boot-utils that referenced this pull request
Mar 16, 2023
This effectively reverts commit 8c78e38 ("boot-qemu: Always use -no-reboot") against the rewrite that occurred in ClangBuiltLinux#91. By applying this unconditionally, we potentially miss out on catching panics. Prior to that change, if a machine panicked and rebooted, it would keep rebooting until timeout killed QEMU, resulting in a non-zero exit code. After that change, QEMU just exits cleanly on reboot. Signed-off-by: Nathan Chancellor <nathan@kernel.org>