All checks were successful
/ distcheck (push) Successful in 28m30s
Make HttpGarbage VSL more helpful
In many cases, vsl under the HttpGarbage tag would not actually contain anything
helpful pointing towards the issue (but rather just the method). This patch
might not be perfect, but an improvement nevertheless.
Diff for b40:
$ grep -E 'vsl\|.*(BogoHeader|HttpGarbage|Status)' /tmp/wip_main/bin/vinyltest/tests/b00040.log >/tmp/a
$ grep -E 'vsl\|.*(BogoHeader|HttpGarbage|Status)' /tmp/wip_garbage/bin/vinyltest/tests/b00040.log >/tmp/b
$ diff -ub /tmp/{a,b}
--- /tmp/a 2026-08-31 16:43:45.326124304 +0200
+++ /tmp/b 2026-08-31 16:43:50.314004381 +0200
@@ -1,25 +1,22 @@
**** v1 vsl| 1001 BogoHeader c 1st header has white space: Host: foo
-**** v1 vsl| 1001 HttpGarbage c GET
**** v1 vsl| 1001 RespStatus c 400
**** v1 vsl| 1003 BogoHeader c 1st header has white space: Host: foo
-**** v1 vsl| 1003 HttpGarbage c GET
**** v1 vsl| 1003 RespStatus c 400
**** v1 vsl| 1005 BogoHeader c Header has ctrl char 0x0d
-**** v1 vsl| 1005 HttpGarbage c GET
+**** v1 vsl| 1005 HttpGarbage c \rHost: foo\r\n\r\n
**** v1 vsl| 1005 RespStatus c 400
**** v1 vsl| 1008 BerespStatus b 200
**** v1 vsl| 1007 RespStatus c 200
**** v1 vsl| 1010 BogoHeader c Header has ctrl char 0x01
-**** v1 vsl| 1010 HttpGarbage c GET
+**** v1 vsl| 1010 HttpGarbage c Bogo: Header\x01More\r\n\r\n
**** v1 vsl| 1010 RespStatus c 400
**** v1 vsl| 1012 BogoHeader c Header has ctrl char 0x0d
-**** v1 vsl| 1012 HttpGarbage c GET
+**** v1 vsl| 1012 HttpGarbage c Bogo: Header\r\r\n\r\n
**** v1 vsl| 1012 RespStatus c 400
**** v1 vsl| 1014 BogoHeader c Header has ctrl char 0x0d
-**** v1 vsl| 1014 HttpGarbage c GET
+**** v1 vsl| 1014 HttpGarbage c Bogo: Header\rMore\r\n\r\n
**** v1 vsl| 1014 RespStatus c 400
**** v1 vsl| 1016 BogoHeader c Missing header name: : Header
-**** v1 vsl| 1016 HttpGarbage c GET
**** v1 vsl| 1016 RespStatus c 400
**** v1 vsl| 1018 RespStatus c 503
**** v1 vsl| 1021 BerespStatus b 200