FPT class doesn't support the rest parameter in storbinary method.

I attached a patch.

I'm changing the title to something clearer (I hope).
The patch I submitted adds the retr optional parameter to the storbinary
method.

I like this. I'd love to see a test of this, though.
Pablo, do you think you could came up with a test? Thanks!

I attached some tests.

According to the RFC, the argument to REST can be any string of
printable characters. However, does it happen for clients to put
non-digits in there?
(that is, are there any implementations where the argument to REST is
something else than the byte offset from the start of file?)

I think that a non-digit REST argument is an error. But I've tested some
ftp servers and they don't return an error code, they just set REST to 0
and return some OK code. Finally, ftplib doesn't check that, so if
someone accidentally passes a non-digit argument it could be a difficult
bug to spot.

The patch looks good to me.
Only two little remarks:
1: I'd create two new separate tests rather than appending them to
existent ones.
2: > self.client.retrbinary('retr', received.append, rest=str(rest))
str() should be useless here.
> According to the RFC, the argument to REST can be any string of
> printable characters. However, does it happen for clients to put
> non-digits in there?
It shouldn't happen but in any case I woulnd't want ftplib to check for
such a kind of thing.
Deciding whether the REST argument is invalid is up to the server, in
which case it will send a 4xx/5xx error response.
> But I've tested some ftp servers and they don't return an
> error code, they just set REST to 0 and return some OK code.
IMHO a bad design choice.

> I think that a non-digit REST argument is an error. But I've tested some
> ftp servers and they don't return an error code, they just set REST to 0
> and return some OK code. Finally, ftplib doesn't check that, so if
> someone accidentally passes a non-digit argument it could be a difficult
> bug to spot.
What I mean is that integer arguments should be accepted as well, since
that's what is logical to produce.

Here is a new patch. It works with both ints and strings.
I'm working on a patch for py3k.

Now that FTP_TLS has been integrated into the trunk, the patch should be
augmented in order to also cover that class. Right now a test is failing:
======================================================================
ERROR: test_storbinary_rest (test.test_ftplib.TestTLS_FTPClassMixin)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/antoine/cpython/__svn__/Lib/test/test_ftplib.py", line
485, in test_storbinary_rest
    self.client.storbinary('stor', f, rest=r)
TypeError: storbinary() got an unexpected keyword argument 'rest'
Apart from that, the patch looks ok.

Thanks Antoine, I'm attaching both patches. Now the test isn't failing.

The patch has been committed in r76546 and r76547. Thank you for your
contribution!

messages: + msg95756

messages: + msg95100

messages: + msg93469

messages: + msg92503
title: ftplib rest support for storbinary -> Restart support in binary upload for ftplib