Issue6192
Created on 2009-06-04 10:32 by kristjan.jonsson, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| disable_nagle.patch | kristjan.jonsson, 2009-06-04 10:32 | |||
| socketserver2.patch | kristjan.jonsson, 2009-06-15 20:50 | |||
| Messages (7) | |||
|---|---|---|---|
| msg88878 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) *  |
Date: 2009-06-04 10:32 | |
It is useful to be able to disable the Nagle algoritm on socket connections from the TCPServer. These are typically used by HTTP servers. If combined with write buffering (setting RequestHangler.wbufsize = -1) it can make sure that http responses are not subject to Nagle/Delayed-ack delays. Disabling Nagle in addition to providing the buffering is necessary to make sure that the final wfile.flush() arrives promptly, in case a previous flush occurred and the final flush is small. A patch is provided. |
|||
| msg88886 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2009-06-04 15:46 | |
Looks ok to me. |
|||
| msg89046 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-06-07 16:44 | |
Committed in revision 73272 |
|||
| msg89062 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2009-06-08 00:19 | |
This patch should be committed to py3k after 3.1 is released. |
|||
| msg89411 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-06-15 20:50 | |
On consideration, it is more appropariate to have the disable_nagle_algorithm as part of StreamRequestHandler rather than in the TCPSockerServer. It then sits right next to the rfile and wfile that affect it. The RequestHandlers aren't documented as extensively as the socket servers, though, so the documentation will have to go. Attached is a patch. |
|||
| msg89657 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-06-24 09:17 | |
Second patch applied in 73546 |
|||
| msg89795 - (view) | Author: Kristján Valur Jónsson (kristjan.jonsson) * |
Date: 2009-06-28 21:35 | |
Merged into py3k in revision 73648 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:49 | admin | set | github: 50442 |
| 2009-06-28 21:36:06 | kristjan.jonsson | set | status: open -> closed keywords: patch, patch, easy |
| 2009-06-28 21:35:22 | kristjan.jonsson | set | keywords:
patch, patch, easy messages: + msg89795 |
| 2009-06-24 09:17:42 | kristjan.jonsson | set | keywords:
patch, patch, easy messages: + msg89657 |
| 2009-06-15 20:50:27 | kristjan.jonsson | set | keywords:
patch, patch, easy files: + socketserver2.patch messages: + msg89411 |
| 2009-06-08 00:19:09 | pitrou | set | status: closed -> open versions: + Python 3.2, - Python 2.7 messages: + msg89062 assignee: kristjan.jonsson |
| 2009-06-07 16:44:28 | kristjan.jonsson | set | status: open -> closed keywords: patch, patch, easy resolution: accepted messages: + msg89046 |
| 2009-06-04 15:46:02 | pitrou | set | keywords:
patch, patch, easy nosy: + pitrou messages: + msg88886 |
| 2009-06-04 10:32:55 | kristjan.jonsson | set | keywords:
patch, patch, easy components: + Library (Lib) |
| 2009-06-04 10:32:40 | kristjan.jonsson | create | |