Currently the zipfile.ZipFile class has no __exit__ atribute, so it
does not work with a with statement as other file objects do.  Can this
be implemented?

Submitted a patch against trunk. Let me know if you need anything else
(doc patch?).

It would be nice if you could provide unit tests.
If you can also provide a patch for the doc, it's even better.

Attached is a patch containing the fix, the updated tests, and the doc
change. Let me know if you have any questions, suggestions, etc.

I think there should also be one or more tests that check if the file is
closed correctly after the __exit__, in normal conditions and possibly
in different situations (e.g. when an error is raised ).
Unlike regular file objects, ZipFile objects don't have a 'closed'
attribute, instead they set self.fp to None when the 'close' method is
called.

Added two tests -- test_close and test_close_on_exception, which check
if fp is None after __exit__ from a normal and exception case.

Done in r77136 (trunk) and r77142 (py3k). Thanks for the patch!

resolution: accepted -> fixed
stage: test needed -> resolved

messages: + msg90932

nosy: + ezio.melotti
messages: + msg90870

keywords: + needs review
stage: needs patch -> test needed

nosy: + brian.curtin
messages: + msg90869

keywords: + patch