Issue46756
Created on 2022-02-15 09:48 by serhiy.storchaka, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 31353 | merged | serhiy.storchaka, 2022-02-15 10:02 | |
| PR 31570 | merged | miss-islington, 2022-02-25 11:31 | |
| PR 31571 | merged | miss-islington, 2022-02-25 11:31 | |
| PR 31572 | merged | miss-islington, 2022-02-25 11:31 | |
| PR 31573 | merged | miss-islington, 2022-02-25 11:31 | |
| Messages (12) | |||
|---|---|---|---|
| msg413280 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2022-02-15 09:48 | |
There is an error in determining a sub-URI in the urllib.request module. Due to it, if the user is authorized for example.org/foo, it gets also access to example.org/foobar. |
|||
| msg413363 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2022-02-16 22:04 | |
Maybe the same as Issue 42766? |
|||
| msg413976 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2022-02-25 11:30 | |
Yes, it is the same. I should search before writing a patch. But for some reasons I prefer my solution over the one proposed in issue42766: The code is clearer and more strict, tests use public API instead of a private method. |
|||
| msg413978 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2022-02-25 11:31 | |
New changeset e2e72567a1c94c548868f6ee5329363e6036057a by Serhiy Storchaka in branch 'main': bpo-46756: Fix authorization check in urllib.request (GH-31353) https://github.com/python/cpython/commit/e2e72567a1c94c548868f6ee5329363e6036057a |
|||
| msg413983 - (view) | Author: miss-islington (miss-islington) | Date: 2022-02-25 11:56 | |
New changeset 4560c7e605887fda3af63f8ce157abf94954d4d2 by Miss Islington (bot) in branch '3.9': bpo-46756: Fix authorization check in urllib.request (GH-31353) https://github.com/python/cpython/commit/4560c7e605887fda3af63f8ce157abf94954d4d2 |
|||
| msg413985 - (view) | Author: miss-islington (miss-islington) | Date: 2022-02-25 11:57 | |
New changeset 2b7e04d61274af03426975fe824ed83eca35b035 by Miss Islington (bot) in branch '3.10': bpo-46756: Fix authorization check in urllib.request (GH-31353) https://github.com/python/cpython/commit/2b7e04d61274af03426975fe824ed83eca35b035 |
|||
| msg414027 - (view) | Author: Ned Deily (ned.deily) * |
Date: 2022-02-25 17:49 | |
New changeset 31fef7edf951fb759004c58ae64df18bc32ea376 by Miss Islington (bot) in branch '3.7': bpo-46756: Fix authorization check in urllib.request (GH-31353) (GH-31573) https://github.com/python/cpython/commit/31fef7edf951fb759004c58ae64df18bc32ea376 |
|||
| msg414347 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2022-03-02 13:49 | |
This is marked as a release blocker so I am holding the alpha release on this. Is there anything we can do to unblock this issue? |
|||
| msg414350 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2022-03-02 13:50 | |
Is something left here, it seems that most PRs are landed |
|||
| msg414351 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2022-03-02 13:50 | |
New changeset 1c9701a3de0566c085e03dddc14a8508aaae349e by Miss Islington (bot) in branch '3.8': bpo-46756: Fix authorization check in urllib.request (GH-31353) (GH-31572) https://github.com/python/cpython/commit/1c9701a3de0566c085e03dddc14a8508aaae349e |
|||
| msg414352 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2022-03-02 13:54 | |
I'm closing this, please reopen if something is missing. |
|||
| msg414465 - (view) | Author: Senthil Kumaran (orsenthil) * |
Date: 2022-03-03 20:14 | |
Pablo, we are good. The PRs were merged in open branches a while ago, and this was tracking security releases backports. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:56 | admin | set | github: 90912 |
| 2022-03-03 20:14:46 | orsenthil | set | messages: + msg414465 |
| 2022-03-02 13:54:11 | pablogsal | set | status: open -> closed priority: release blocker -> messages: + msg414352 resolution: fixed |
| 2022-03-02 13:50:42 | pablogsal | set | messages: + msg414351 |
| 2022-03-02 13:50:17 | pablogsal | set | messages: + msg414350 |
| 2022-03-02 13:49:51 | pablogsal | set | messages: + msg414347 |
| 2022-02-25 17:49:59 | ned.deily | set | messages: + msg414027 |
| 2022-02-25 12:00:31 | serhiy.storchaka | link | issue42766 superseder |
| 2022-02-25 11:57:34 | miss-islington | set | messages: + msg413985 |
| 2022-02-25 11:56:23 | miss-islington | set | messages: + msg413983 |
| 2022-02-25 11:34:03 | serhiy.storchaka | set | priority: high -> release blocker nosy: + ned.deily, pablogsal, lukasz.langa |
| 2022-02-25 11:31:24 | miss-islington | set | pull_requests: + pull_request29695 |
| 2022-02-25 11:31:19 | miss-islington | set | pull_requests: + pull_request29694 |
| 2022-02-25 11:31:15 | miss-islington | set | pull_requests: + pull_request29693 |
| 2022-02-25 11:31:12 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request29692 |
| 2022-02-25 11:31:09 | serhiy.storchaka | set | messages: + msg413978 |
| 2022-02-25 11:30:32 | serhiy.storchaka | set | messages: + msg413976 |
| 2022-02-16 22:04:34 | martin.panter | set | nosy:
+ martin.panter messages: + msg413363 |
| 2022-02-15 10:03:29 | serhiy.storchaka | set | title: Incorrect -> Incorrect authorization check in urllib.request |
| 2022-02-15 10:02:26 | serhiy.storchaka | set | keywords:
+ patch stage: patch review pull_requests: + pull_request29502 |
| 2022-02-15 09:48:07 | serhiy.storchaka | create | |