Issue4365
Created on 2008-11-20 15:55 by cdavid, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| msvcrt_version_info.diff | cdavid, 2008-11-20 15:55 | |||
| Messages (4) | |||
|---|---|---|---|
| msg76112 - (view) | Author: Cournapeau David (cdavid) | Date: 2008-11-20 15:55 | |
This patch if the first part to follow discussion on python-list concerning problems when using distutils.config.try_run with mingw and manifest problems on windows for python 2.6 (or any python built with recent VS). It simply adds strings constant got the msvcrt module, so that they can be queried in distutils to generate manifest on the fly if needed. I don't know which approach is best to deal with conditional compilation: for now, I simply do not add the constants if the constants are not defined at the C level, but this does not strike as a great idea to me. |
|||
| msg76654 - (view) | Author: Martin v. Löwis (loewis) *  |
Date: 2008-11-30 19:29 | |
Thanks for the patch. Committed (with modifications) as r67455. Barry, I would like to apply this to both 2.6 and 3.0. Ok? |
|||
| msg76664 - (view) | Author: Barry A. Warsaw (barry) * |
Date: 2008-11-30 20:16 | |
Go for it Martin. |
|||
| msg76675 - (view) | Author: Martin v. Löwis (loewis) * |
Date: 2008-12-01 04:53 | |
Merged into 2.6 as r67466, Benjamin had already merged it for 3k as r67461. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:41 | admin | set | nosy:
+ benjamin.peterson github: 48615 |
| 2008-12-01 04:53:13 | loewis | set | status: open -> closed messages: + msg76675 versions: - Python 2.6, Python 3.0 |
| 2008-11-30 20:17:00 | barry | set | resolution: accepted messages: + msg76664 versions: + Python 2.6, Python 3.0 |
| 2008-11-30 19:29:37 | loewis | set | priority: release blocker assignee: barry messages: + msg76654 nosy: + barry, loewis |
| 2008-11-20 15:55:43 | cdavid | create | |