Issue3382
Created on 2008-07-16 18:28 by eric.smith, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue3382_trunk.patch | mark.dickinson, 2009-11-29 10:38 | |||
| issue3382_trunk-1.patch | eric.smith, 2009-11-29 17:06 | |||
| Messages (12) | |||
|---|---|---|---|
| msg69811 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2008-07-16 18:28 | |
See http://mail.python.org/pipermail/python-dev/2008-July/081242.html for the discussion. Basically, 'F' did the same as 'f' because it was assumed that neither would ever produce an exponent. But they do, for numbers greater than about 1e50. Also, 'F' should produce 'NAN' for cases where 'f' produces 'nan'. |
|||
| msg69897 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2008-07-17 18:35 | |
Implemented for trunk in r65069; for py3k in r65073. |
|||
| msg69901 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2008-07-17 19:21 | |
Changes backed out, pending fixing on Windows. |
|||
| msg71945 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2008-08-25 17:28 | |
Unfortunately, I missed the window to get these into 3.0 and 2.6. Better luck for 3.1 and 2.7! |
|||
| msg86838 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-04-30 01:13 | |
If http://bugs.python.org/issue5859 is implemented, then this issue really just becomes making sure NAN and INF are uppercase. |
|||
| msg87092 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-05-04 00:58 | |
With the implementation of issue5859 (py3k only), the only case where this matters in NAN and INF. I'm going to address those in 3.1, and not make any change for 2.x. |
|||
| msg87330 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-05-06 13:16 | |
Checked in to py3k in 72398. I'm reconsidering whether to make this change in 2.7. I might make the change there, I'll have to check on the impacts. |
|||
| msg95802 - (view) | Author: Mark Dickinson (mark.dickinson) * ![]() |
Date: 2009-11-29 10:38 | |
Eric, any further thoughts about making this change in 2.7? Here's a patch that does it (I think). |
|||
| msg95805 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-11-29 14:15 | |
Thanks for looking at this, Mark. Your patch looks okay to me, but Objects/stringlib/formatter.h still has some 'F' -> 'f' logic in it, although it turns out that it's wrong: #if PY_VERSION_HEX < 0x0301000 /* 'F' is the same as 'f', per the PEP */ /* This is no longer the case in 3.x */ if (type == 'F') type = 'f'; #endif Note that it's missing a zero on the end, so this code is never (and I guess never was) executed. I'll remove it and add a test. It also looks like complex is still mapping 'F' to 'f'. I'll fix that, too, and add a test for it. Thanks again. |
|||
| msg95807 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-11-29 17:06 | |
Here's a patch which adds some tests and fixes complex. I'm currently testing with PY_NO_SHORT_FLOAT_REPR on Windows. If that's okay, and if you don't have any objections, I'll commit this. While I'm at it I'll modify Objects/stringlib/formatter.h in py3k to keep them it sync with trunk. |
|||
| msg95808 - (view) | Author: Mark Dickinson (mark.dickinson) * ![]() |
Date: 2009-11-29 17:12 | |
Looks good to me. |
|||
| msg95810 - (view) | Author: Eric V. Smith (eric.smith) * ![]() |
Date: 2009-11-29 17:41 | |
Committed (with a few more tests) in r76583. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:36 | admin | set | github: 47632 |
| 2009-11-29 17:41:25 | eric.smith | set | status: open -> closed resolution: accepted messages: + msg95810 stage: resolved |
| 2009-11-29 17:12:13 | mark.dickinson | set | messages: + msg95808 |
| 2009-11-29 17:07:08 | eric.smith | set | versions: + Python 2.7 |
| 2009-11-29 17:06:56 | eric.smith | set | files:
+ issue3382_trunk-1.patch messages: + msg95807 |
| 2009-11-29 14:15:04 | eric.smith | set | messages: + msg95805 |
| 2009-11-29 10:38:58 | mark.dickinson | set | files:
+ issue3382_trunk.patch keywords: + patch messages: + msg95802 |
| 2009-05-06 13:16:24 | eric.smith | set | messages: + msg87330 |
| 2009-05-04 00:58:45 | eric.smith | set | messages:
+ msg87092 versions: - Python 2.7 |
| 2009-04-30 01:13:37 | eric.smith | set | messages: + msg86838 |
| 2009-04-12 16:26:22 | eric.smith | set | nosy:
+ mark.dickinson |
| 2008-08-25 17:28:45 | eric.smith | set | messages:
+ msg71945 versions: + Python 3.1, Python 2.7, - Python 2.6, Python 3.0 |
| 2008-07-17 19:21:37 | eric.smith | set | status: closed -> open resolution: accepted -> (no value) messages: + msg69901 |
| 2008-07-17 18:35:24 | eric.smith | set | status: open -> closed resolution: accepted messages: + msg69897 |
| 2008-07-16 18:28:14 | eric.smith | create | |
