Issue1330538
Created on 2005-10-19 02:46 by skip.montanaro, last changed 2022-04-11 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| xmlrpclib.diff | skip.montanaro, 2005-10-22 21:01 | |||
| Messages (6) | |||
|---|---|---|---|
| msg48876 - (view) | Author: Skip Montanaro (skip.montanaro) * ![]() |
Date: 2005-10-19 02:46 | |
Recent changes to xmlrpclib provided improved support for
datetime objects. This patch improves that by adding
support for comparison of xmlrpclib.DateTime objects with
datetime.{datetime,date,time} objects.
On the Mojam web server I run with an xmlrpclib module
that is close to what Python 2.5 will have, though I
use Python 2.3.4. The datetime support breaks the
antispam BadContent support in MoinMoin's security
policy because datetime objects and xmlrpclib.DateTime
objects can't be compared. I believe this patch
should solve that (though I haven't had time to test that
yet). I've added new test cases to check support for
comparing datetime.{datetime,date} objects with DateTime
objects. I still need to add a test case to check support
for comparing datetime.time objects.
I believe something like this needs to go in 2.5 (maybe
this should have been a bug report instead of patch).
All Python test cases pass.
|
|||
| msg48877 - (view) | Author: Skip Montanaro (skip.montanaro) * ![]() |
Date: 2005-10-22 21:01 | |
Logged In: YES user_id=44345 Based on inputs from python-dev I removed conversions of and comparisons with datetime.date and datetime.time objects. I also tweaked it to work with Python 2.2 through Python 2.5 (datetime support is unavailable in Python2.2). New patch is attached. I'd simply check this in except I've not done anything with rich comparisons before. Assigning to Fred since he's familiar with the code. |
|||
| msg55564 - (view) | Author: Skip Montanaro (skip.montanaro) * ![]() |
Date: 2007-09-01 17:44 | |
Fred, can we move this forward? |
|||
| msg62578 - (view) | Author: A.M. Kuchling (akuchling) * ![]() |
Date: 2008-02-20 00:11 | |
Skip, I can look at xmlrpclib issues. |
|||
| msg62763 - (view) | Author: A.M. Kuchling (akuchling) * ![]() |
Date: 2008-02-23 16:13 | |
The patch looks OK. The python-dev discussion starts at http://mail.python.org/pipermail/python-dev/2005-October/057514.html. I'm nervous about removing the ability to pass a date or time to the constructor, but the consensus was that this conversion was a bad idea, so I'll apply the patch as-is, and update the docs. |
|||
| msg62765 - (view) | Author: A.M. Kuchling (akuchling) * ![]() |
Date: 2008-02-23 16:23 | |
Committed to 2.6 trunk in rev. 60991. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:56:13 | admin | set | github: 42498 |
| 2008-02-23 16:23:37 | akuchling | set | status: open -> closed resolution: accepted messages: + msg62765 |
| 2008-02-23 16:13:21 | akuchling | set | messages: + msg62763 |
| 2008-02-20 00:11:25 | akuchling | set | assignee: fdrake -> akuchling messages: + msg62578 nosy: + akuchling |
| 2007-09-01 17:44:59 | skip.montanaro | set | messages: + msg55564 |
| 2005-10-19 02:46:18 | skip.montanaro | create | |

