The apply worker tracked the final LSN of the remote transaction being applied in a separate global variable remote_final_lsn, even though apply_error_callback_arg already tracked the same transaction's xid and finish LSN for error context reporting, and both were updated together at the same places.

Rename ApplyErrorCallbackArg to ApplyRemoteCtx and treat its remote_xid/finish_lsn pair as the generic descriptor of the remote transaction currently being applied, replacing all uses of remote_final_lsn so the redundant global can be removed.

There is no behavior change.

Recording the remote transaction being applied in a single place should also help the proposed conflict log table patch, which needs the same information when logging a conflict.

• Author: Zhijie Hou houzj.fnst@fujitsu.com
• Author: Amit Kapila amit.kapila16@gmail.com
• Reviewed-by: Hayato Kuroda kuroda.hayato@fujitsu.com
• Reviewed-by: shveta malik shveta.malik@gmail.com
• Reviewed-by: Dilip Kumar dilipbalaut@gmail.com
• Discussion